Fix exp rename typo #4889
Merged
Fix exp rename typo #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link Check ReportThere were no links to check! |
dberenbaum
reviewed
Sep 29, 2023
dberenbaum
reviewed
Sep 29, 2023
| experiment Experiments to rename. | ||
| name Name of new experiment. | ||
| experiment Experiment to rename | ||
| name Name of new experiment |
There was a problem hiding this comment.
Sorry, just committed a suggestion to revert the change on this line, but was there a reason behind wanting to change it @mattseddon?
There was a problem hiding this comment.
the experiment is still the same, it just has a new name. It is not a new experiment
dberenbaum
reviewed
Oct 3, 2023
dberenbaum
approved these changes
Oct 3, 2023
|
@mattseddon We should also change the CLI help text, although it's not critical. |
I'll raise a PR |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Noticed this whilst looking at iterative/vscode-dvc#4616